王益龙 #17
Open
王益龙 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckymark
reviewed
Mar 15, 2021
| #include <time.h> | ||
| #include <string.h> | ||
| //constants | ||
| enum{ N = 1000 , sleep_time = 50}; |
| int primes[N], cnt; | ||
| int sieved[N]; | ||
|
|
||
| void get_primes(int n); |
level1/p09_maze/maze.c
Outdated
| srand((unsigned)time(0)); | ||
| c_r = c_c = 0; | ||
| if (!set) set = (int *)malloc(Height * Width * sizeof(int)); | ||
| for (i = 0; i < Height * Width; ++ i) set[i] = i; |
level1/p09_maze/maze.c
Outdated
| c_r = c_c = 0; | ||
| if (!set) set = (int *)malloc(Height * Width * sizeof(int)); | ||
| for (i = 0; i < Height * Width; ++ i) set[i] = i; | ||
| if (!map) map = (int **)malloc(Height * sizeof(int *)); |
| } | ||
| void dig() { | ||
| while (1) { | ||
| int p1 = find(0), p2 = find(Height * Width - 1); |
level1/p09_maze/maze.c
Outdated
| int cnt = 0; | ||
| for (i = 0; i < 4; ++ i) { | ||
| int nr = r + dir[i][0], nc = c + dir[i][1]; | ||
| if (nr >= 0 && nr < Height && nc >= 0 && nc < Width && !map[nr][nc]) { |
There was a problem hiding this comment.
这种长表达式，我有时会提到一个中间变量中，这样可以给它一个名字来表达这个表达式的意图；根据情况，有时甚至会提成一个函数
level1/p09_maze/maze.c
Outdated
| int i; | ||
| for (i = 0; i < 4; ++ i) { | ||
| int nr = r + dir[i][0], nc = c + dir[i][1]; | ||
| if (nr >= 0 && nr < Height && nc >= 0 && nc < Width && !map[nr][nc]) { |
There was a problem hiding this comment.
上面那个表达式如果提成了函数，这里就可以复用了；
当然，并不需要提前预判这种情况，而是当再次看到老朋友（上面出现过的表达式）时，再重构提取函数就好了
level1/p10_pushBoxes/pushBoxes.c
Outdated
| } | ||
| //箱子前方归位点 | ||
| else if (NotOut(b_n_r,b_n_c) && maps[cur_map][b_n_r][b_n_c] == Dest) { | ||
| maps[cur_map][n_r][n_c] = PInDest; |
|
多谢老师指点 |
|
话说有人通关了我那个推箱子吗，对了，你们还能仿照我地图的格式自己DIY一个地图玩玩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FInished some