Level 1 finished #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckymark
reviewed
Mar 9, 2021
.vscode/launch.json
Outdated
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
.vscode下的文件一般不用提交到github，可以看看.gitignore的用法: https://docs.github.com/cn/github/using-git/ignoring-files
| cin >> x; | ||
| if (judge(x))cout << "yes"; | ||
| else cout << "no"<<endl; | ||
| system("pause"); |
There was a problem hiding this comment.
缩进不对，可以用IDE的自动format处理一下，vs、clion等IDE都有的
level1/p02_isPrime/source.cpp
Outdated
| int main() { | ||
| int x; | ||
| cin >> x; | ||
| if (judge(x))cout << "yes"; |
There was a problem hiding this comment.
1）if语句的条件判断，和执行分支语句，最好分行写，这样单步跟踪和断点调试的时候更方便
2）Google的编程规范中，分支语句即使只有一行，也要求用大括号抱起来，可以减少一些意外的错误
像这样：
if (judge(x)) {
cout << "yes";
}
luckymark
reviewed
Mar 15, 2021
| for (unsigned i = 0; i < len; i = i + 1) | ||
| { | ||
| srand((unsigned)time(NULL)); | ||
| char a = input[i][0] * 8 + input[(i + 1) % len][0] * 2 + rand() % 2 + 97; |
| int hanoi(int n) | ||
| { | ||
| if (saves[n] == 0) | ||
| { |
There was a problem hiding this comment.
啊，是我没写清楚需求，要求打印出移动的步骤，例如：
A->C
A->B
B->C
...
level1/p09_maze/source.cpp
Outdated
| } | ||
| void print(int **Maze){ | ||
| for (int i = 0; i < L; i++) { | ||
| for (int j = 0; j < L; j++) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.