Add abstract definition for debug_message #1927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To make it clearer that
debug_message
must be implemented onResponse
.Description
I am using lucky to build a microservice that accepts protobuf definitions over http so I created my own
ProtobufResponse
class to stream the protobuf response straight into the response io. While implementing it I discovered that you also have to implementdebug_message
as well as it is required by renderable:lucky/src/lucky/renderable.cr
Lines 194 to 196 in 2c1433d
Checklist
crystal tool format spec src
./script/setup
./script/test