Fixing the issue that requests may not be sent due to cache of fetch #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hmm, so it was a caching problem. Nice catch! About the tests, no problem. I fixed them here. I am gonna close your PR in favor of the new one. Which web server are you using to serve your script? Is it Web Server for Chrome or a custom one? I never had cache problems with that app, so I believe you might be using a different server. |
|
I tried web server for chrome and node static. had the same issue with both. |
|
What's your OS? |
|
I am using Mac, however, one of my friends who is using windows and web server for chrome is having the same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally figure out why some requests may not be sent out. Here is the reference.
However, this fix does break 2 unit test cases. I can also try to fix the test cases if you prefer.