Remove zero init and constant biasing for to_gate
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucidrains
reviewed
Oct 3, 2024
alphafold3_pytorch/attention.py
Outdated
| nn.init.constant_(gate_linear.bias, init_gate_bias) | ||
|
|
||
| self.to_gates = gate_linear | ||
| self.to_gates = nn.Sequential(nn.Linear(dim, dim_inner, bias = False), nn.Sigmoid()) |
There was a problem hiding this comment.
want to use the LinearNoBias here?
There was a problem hiding this comment.
Had to duplicate to avoid circular imports
There was a problem hiding this comment.
yeah that's fine, dryness is overrated
lucidrains
reviewed
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention pair biasing uses a simple linear (no bias) and a sigmoid function to gate the attention output logits, as shown below
