Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added calendar-sync icon #2590

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

chessurisme
Copy link
Contributor

close #2071

What is the purpose of this pull request?

  • New Icon

Description

Added new calendar-sync icon.

Icon use case

Here are some more use cases:

  • Cron jobs scheduling: This could be scheduling a recurring job to handle invalid urls in database.
    Recurring Events or Limited time offers or promotions: This could be a flash sale, a seasonal promotion, or a free trial offer.
  • Tasks or reminders that need to be repeated: This could be taking medication, watering plants, or walking the dog.
  • Loan auto periodic payment This could be for handling loan installments as reminder or auto.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @danielbayley
  • I've based them on the following Lucide icons: folder-sync, calendar-heart
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Added or changed icons

icons/calendar-sync.svg

Preview cohesion icons/message-square-text.svg
icons/calendar-sync.svg
icons/calculator.svg
Preview stroke widths icons/calendar-sync.svg
icons/calendar-sync.svg
icons/calendar-sync.svg
DPI Preview (24px) icons/calendar-sync.svg
Icon X-rays icons/calendar-sync.svg
Icon Diffs icons/calendar-sync.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const CalendarSyncIcon = createLucideIcon('CalendarSync', [
  ["path",{"d":"M11 10v4h4"}],
  ["path",{"d":"m11 14 1.535-1.605a5 5 0 0 1 8 1.5"}],
  ["path",{"d":"M16 2v4"}],
  ["path",{"d":"m21 18-1.535 1.605a5 5 0 0 1-8-1.5"}],
  ["path",{"d":"M21 22v-4h-4"}],
  ["path",{"d":"M21 8.5V6a2 2 0 0 0-2-2H5a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h4.3"}],
  ["path",{"d":"M3 10h4"}],
  ["path",{"d":"M8 2v4"}]
])

@chessurisme
Copy link
Contributor Author

Everytime I pushed I have this annoying four first commits. I need to troubleshoot.

@jguddas
Copy link
Member

jguddas commented Nov 8, 2024

Everytime I pushed I have this annoying four first commits. I need to troubleshoot.

You just have random stuff in your main branch, just have to force remove it to be the same as the lucide branch.

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has box-select removed in the PR.

@chessurisme
Copy link
Contributor Author

it is already removed

@karsa-mistmere
Copy link
Member

The sync arrows are .5px off grid vertically.

@chessurisme
Copy link
Contributor Author

The sync arrows are .5px off grid vertically.

Already fixed!

@chessurisme
Copy link
Contributor Author

Time to go! 🚀

icons/calendar-sync.svg Outdated Show resolved Hide resolved
Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refresh icon has a 2px gap violation and is not sympathetical

@chessurisme
Copy link
Contributor Author

chessurisme commented Nov 19, 2024

How about this, I moved the refresh icon so there will be 2px on each sides:
icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Nov 19, 2024

How about this, I moved the refresh icon so there will be 2px on each sides: iconsOpen lucide studio

That looks pretty good, we should close the gap at the bottom like this:

icons
Open lucide studio

@chessurisme
Copy link
Contributor Author

I also think about that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icon request] calendar-repeat
3 participants