Add @types/react as peer dep to lucide-react #2549
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Without this, in a PNPM + bazel setup, TypeScript cannot find react typings:
Since the exported types depend on
@types/react
, I think this package should either declare@types/react
as a direct or a peer dep. I chose a peer dep in this PR to mirror what's being done withreact
, but happy to change it! I also wasn't sure if a fixed version or*
would be preferred either.In my repo, I was able to confirm this fixes my issue by adding a packageExtension in my root
package.json
:Before Submitting