Add TransportSocket trait for injecting the socket into netcode transports #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets to netcode transports
4 tasks
Shatur
suggested changes
Feb 4, 2024
| /// Implementation of [`TransportSocket`] for `UdpSockets`. | ||
| #[derive(Debug)] | ||
| pub struct NativeSocket { | ||
| socket: UdpSocket, |
There was a problem hiding this comment.
Maybe implement From to make it easier to initialize?
And I would declare it as NativeSocket(UdpSocket).
There was a problem hiding this comment.
Can't do it, new() returns a Result.
|
|
||
| #[derive(Debug)] | ||
| #[cfg_attr(feature = "bevy", derive(bevy_ecs::system::Resource))] | ||
| pub struct NetcodeClientTransport { | ||
| socket: UdpSocket, | ||
| socket: Box<dyn TransportSocket>, |
There was a problem hiding this comment.
Have you considered using generic instead?
There was a problem hiding this comment.
Yeah generic would get rid of the dynamic dispatch, but then all user code that gets the netcode transport resources has to parameterize on the socket type.
|
Closing this as implemented in renet2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the existing
netcodetransports can be reused for the in-memory transport and WebTransport, which should reduce diffs/complexity for both of them, and allows WebTransport to usenetcodeConnectTokens which are an essential part of the architecture.This abstraction would also make it very easy to insert custom
TransportSocketsthat artificially add packet loss and latency for testing purposes. Other performance characteristics of the architecture would remain the same with that approach (compared to writing entirely new transports with injected packet loss/latency), which is important for high-quality testing.The main disadvantage of this approach is WebTransport would end up double-encrypting all packets. It may be possible to configure renet not to encrypt packets if the user can promise they were already encrypted. Needs careful thought.