Do not run client systems when the client is disconnected #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
force-pushed
the
run_conditions
branch
from
fff33e2 to
defab46
Compare
|
Wrapping that into client_connected() function would have better sound. |
We need this to run when connecting and connected. |
UkoeHB
force-pushed
the
run_conditions
branch
from
defab46 to
1f1c251
Compare
UkoeHB
force-pushed
the
run_conditions
branch
from
1f1c251 to
ba2b729
Compare
|
This PR has a bug, since the client needs to update at least once while disconnected in order to send a disconnect packet to the server. The correct run condition is here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running systems for a disconnected client just spams transport errors.