Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ http exceptions and default exception handlers #9

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

lucas-labs
Copy link
Owner

@lucas-labs lucas-labs commented Nov 22, 2023

Implement changes as proposed on #4

  • Implement exception handling, with schema responses similar to nestjs + http exceptions
  • Patch openai schemas to accordingly reflect the changes (http 400 for request validation errors and the new common schema for errors replicating those of nestjs)

Note

Just that for now, as we depend on #6 to be able to implement per-controller exception handlers (and to even think on a
per-route functionality)
Nest equivalent functionality

@lucas-labs lucas-labs linked an issue Nov 22, 2023 that may be closed by this pull request
2 tasks
@lucas-labs lucas-labs merged commit c018771 into master Nov 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the 4-exception-handling branch November 22, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 exception handling and http exceptions
1 participant