Fixes after merging the dev

lucafedeli88 · Nov 9, 2023 · 6aba6b8 · 6aba6b8
1 parent 55976fc
commit 6aba6b8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/test/CoreTest.cpp b/test/CoreTest.cpp
@@ -49,6 +49,7 @@ TEST_CASE("attribute_dtype_test", "[core]")
     REQUIRE(Datatype::CHAR == a.dtype);
     {
         // check that copy constructor works
+        // NOLINTNEXTLINE(performance-unnecessary-copy-initialization)
         [[maybe_unused]] Attribute b = a;
     }
     {

diff --git a/test/SerialIOTest.cpp b/test/SerialIOTest.cpp
@@ -596,7 +596,13 @@ struct NonCopyableDeleter : std::function<void(T *)>
     {}
     NonCopyableDeleter(NonCopyableDeleter const &) = delete;
     NonCopyableDeleter &operator=(NonCopyableDeleter const &) = delete;
+    /*
+     * MSVC does not recognize these when declaring noexcept and this is
+     * for a test only anyway.
+     */
+    // NOLINTNEXTLINE(performance-noexcept-move-constructor)
     NonCopyableDeleter(NonCopyableDeleter &&) = default;
+    // NOLINTNEXTLINE(performance-noexcept-move-constructor)
     NonCopyableDeleter &operator=(NonCopyableDeleter &&) = default;
 };
 } // namespace detail