fix: clone reponse in put() (#3)

lucacasonato · Mar 18, 2021 · 39f7a38 · 39f7a38
1 parent 107c962
commit 39f7a38
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/in_memory_test.ts b/in_memory_test.ts
@@ -21,7 +21,7 @@ Deno.test("[in memory] cache, retrieve, delete", async () => {
       originalResp.headers.get("server"),
       cachedResp.headers.get("server"),
     );
-    assertEquals(await cachedResp.text(), "Hello World");
+    assertEquals(await originalResp.text(), await cachedResp.text());
 
     await cache.delete("https://deno.land");
 

diff --git a/mod.ts b/mod.ts
@@ -51,9 +51,8 @@ export class Cache {
   }
 
   async put(request: RequestInfo, response: Response): Promise<void> {
-    const req = request instanceof Request
-      ? request.clone()
-      : new Request(request);
+    const req = request instanceof Request ? request : new Request(request);
+    response = response.clone();
 
     const status = response.status;
     const headers = Object.fromEntries(response.headers.entries());

diff --git a/redis_test.ts b/redis_test.ts
@@ -21,7 +21,7 @@ Deno.test("[redis] cache, retrieve, delete", async () => {
       originalResp.headers.get("server"),
       cachedResp.headers.get("server"),
     );
-    assertEquals(await cachedResp.text(), "Hello World");
+    assertEquals(await originalResp.text(), await cachedResp.text());
 
     await cache.delete("https://deno.land");