Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32769: Implement streak detection and masking in single frame processing #845

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

mrawls
Copy link
Contributor

@mrawls mrawls commented Oct 18, 2023

This PR adds maskStreaksTask (with no bells or whistles) as a default step to single frame processing.

It supports both main "modes" of single frame: the original isr -> characterizeImage -> calibrate AS WELL AS the newfangled isr -> calibrateImage.

The result is that linear DETECTED features are also masked as STREAK.

@mrawls mrawls requested a review from bsmartradio October 18, 2023 22:49
This implementation is in both characterizeImage -> calibrate
as well as the newer calibrateImage. It adds streak and streakCenter
flag columns to the Source, Object, and ForcedSource schemas.
@mrawls mrawls changed the title DM-32769: Implement streak detection and masking in AP DM-32769: Implement streak detection and masking in single frame processing Oct 25, 2023
Copy link
Contributor

@bsmartradio bsmartradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@mrawls mrawls merged commit b50b65b into main Oct 26, 2023
2 checks passed
@mrawls mrawls deleted the tickets/DM-32769 branch October 26, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants