DM-40746: Fix size and shape of HiPS Allsky file. #831
Conversation
| row = math.floor(pix_num//n_tiles_per_side) | ||
| column = pix_num % n_tiles_per_side | ||
| row = math.floor(pix_num//n_tiles_wide) | ||
| column = pix_num % n_tiles_wide |
There was a problem hiding this comment.
Row and column both use the width?
There was a problem hiding this comment.
Yeah, it's div and mod to get x/y from an ordered list.
erykoff
force-pushed
the
tickets/DM-40746
branch
from
be0b2e7 to
5f27628
Compare
|
I have removed the commit which allows you to specify the Allsky filetype since it cannot be specified independently of the rest of the hips images. |
|
Regarding the filetype specification: even though it can't in practice be specified to be different from the filetype of the underlying tiles, it's still a problem that the filetype is hard-coded. So it was reasonable for there to be a parameter for the filetype - which, however, should be used both for the input regex and for the output I think we need it to be easier for us to pick between PNG and JPEG in the future. |
|
Yes indeed, and that's what DM-40747 can do, but it has to be done for everything at once. |
This also adds the ability to specify the Allsky file to be a jpeg or png.