Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47505: Don't raise when --dataset-query-constraint args are irrelevant. #455

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Nov 11, 2024

They might be relevant for a different subgraph, and this option needs to be usable on multi-subgraph pipelines where the subgraphs don't have overall inputs in common.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

They might be relevant for a different subgraph, and this option needs
to be usable on multi-subgraph pipelines where the subgraphs don't have
overall inputs in common.
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.22%. Comparing base (591c0c7) to head (fa2bc96).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../pipe/base/all_dimensions_quantum_graph_builder.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   83.22%   83.22%           
=======================================
  Files         103      103           
  Lines       12227    12227           
  Branches     1546     1546           
=======================================
  Hits        10176    10176           
  Misses       1641     1641           
  Partials      410      410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hlin730 hlin730 assigned hlin730 and unassigned hlin730 Nov 11, 2024
@hlin730 hlin730 self-requested a review November 11, 2024 20:24
Copy link

@hlin730 hlin730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with these changes that LSSTComCam DRP step3b indeed generates quantum graph rapidly when --dataset-query-constraints for all 3 step3b sub-graphs are specified together, without raising an error as it did before.

@TallJimbo TallJimbo merged commit 79fcafa into main Nov 11, 2024
13 of 14 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-47505 branch November 11, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants