-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-47328: Experimental command to copy files based on a graph #454
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 83.00% 83.22% +0.21%
==========================================
Files 102 103 +1
Lines 12135 12227 +92
Branches 1535 1546 +11
==========================================
+ Hits 10073 10176 +103
+ Misses 1655 1641 -14
- Partials 407 410 +3 ☔ View full report in Codecov by Sentry. |
@andy-slac it looks like I should add |
That looks natural, indeed. Maybe generalize it a bit and add options to include init inputs/outputs and intermediates? Something like
? |
Looking at the loops that are involved with the same loop over quanta running for both inputs and outputs, I'm edging towards a single |
6b11830
to
d262022
Compare
@timj Thank you very much! Indeed, I was able to retrieve all inputs used in a quantum graph with
|
ba321ac
to
261ac6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I do not have an opinion on command name for CLI, retrieve-artifacts-for-quanta
looks reasonable.
946fc9c
to
5f4f16d
Compare
427630b
to
9465cbd
Compare
Requiers lsst/daf_butler#1111
cc/ @tgoldina I think this might do what you need. Please give it a try and let me know. I might change the name of the command etc.
Checklist
doc/changes