DM-44583: support manual config outputs in mocking system #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we just looked at the storage classes to identify config, log, and metadata datasets that we shouldn't mock because they're written by the execution system. But this prevented tasks from being able to have regular outputs using those storage classes; we *do* want to mock those.
This works around the fact we can't necessarily see the full pipeline graph in mock_pipeline_graph and hence can't identify when a special unmocked output (e.g. a config) is read in by a later task in order to mark the dataset type as unmocked in the later task.
TallJimbo
force-pushed
the
tickets/DM-44583
branch
from
74619de to
becea23
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
- Coverage 81.07% 80.92% -0.16%
==========================================
Files 95 95
Lines 10833 10818 -15
Branches 2060 2064 +4
==========================================
- Hits 8783 8754 -29
- Misses 1705 1718 +13
- Partials 345 346 +1 ☔ View full report in Codecov by Sentry. |
erykoff
approved these changes
May 29, 2024
|
There might need to be some sort of uv patch required as well? |
Virtual env environment variable is no longer supported.
TallJimbo
force-pushed
the
tickets/DM-44583
branch
from
b6a005f to
093c821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes