Skip to content

Commit

Permalink
Adapt to middleware-internal API changes.
Browse files Browse the repository at this point in the history
  • Loading branch information
TallJimbo committed Sep 6, 2024
1 parent 3f710bc commit 8044d6f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 1 addition & 4 deletions python/lsst/pipe/base/prerequisite_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,7 @@ def __init__(
self.constraint_dimensions = self.task_node.dimensions
if self.lookup_function is None:
for family in self.dataset_type_node.dimensions.spatial - self.task_node.dimensions.spatial:
best_spatial_element = family.choose(
self.dataset_type_node.dimensions.elements,
self.dataset_type_node.dimensions.universe,
)
best_spatial_element = family.choose(self.dataset_type_node.dimensions)

Check warning on line 157 in python/lsst/pipe/base/prerequisite_helpers.py

View check run for this annotation

Codecov / codecov/patch

python/lsst/pipe/base/prerequisite_helpers.py#L157

Added line #L157 was not covered by tests
if isinstance(best_spatial_element, SkyPixDimension):
self.dataset_skypix[best_spatial_element.name] = best_spatial_element
else:
Expand Down
2 changes: 2 additions & 0 deletions python/lsst/pipe/base/tests/mocks/_data_id_match.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ def match(self, dataId: DataId) -> bool:
Raised when expression includes valid but unsupported syntax, e.g.
function call.
"""
if self.tree is None:
return True

Check warning on line 175 in python/lsst/pipe/base/tests/mocks/_data_id_match.py

View check run for this annotation

Codecov / codecov/patch

python/lsst/pipe/base/tests/mocks/_data_id_match.py#L175

Added line #L175 was not covered by tests
visitor = _DataIdMatchTreeVisitor(dataId)
result = self.tree.visit(visitor)
if not isinstance(result, bool):
Expand Down

0 comments on commit 8044d6f

Please sign in to comment.