Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48159 : Make Coverage import optional #316

Merged
merged 3 commits into from
Dec 16, 2024
Merged

DM-48159 : Make Coverage import optional #316

merged 3 commits into from
Dec 16, 2024

Conversation

tcjennings
Copy link
Contributor

  • Makes coverage import optional and lazy-loads it.
  • Bump minimum Python to 3.11 (matching dependency for daf_butler).
  • Add packaging extra option for coverage; i.e., pip users can specify pip install lsst-ctrl-mpexec[coverage]

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@tcjennings tcjennings force-pushed the tickets/DM-48159 branch 2 times, most recently from 40c9121 to 11535b7 Compare December 16, 2024 15:14
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.03%. Comparing base (63cee0f) to head (7ed95cd).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/test_cliScript.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   89.73%   90.03%   +0.30%     
==========================================
  Files          50       50              
  Lines        4520     4536      +16     
  Branches      414      414              
==========================================
+ Hits         4056     4084      +28     
+ Misses        340      327      -13     
- Partials      124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@tcjennings tcjennings merged commit e4484fe into main Dec 16, 2024
16 checks passed
@tcjennings tcjennings deleted the tickets/DM-48159 branch December 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants