Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41321: Add try-except block to manifest checker so that failure to get butler logs does not make error reporting impossible #272

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

eigerx
Copy link
Contributor

@eigerx eigerx commented Nov 1, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@eigerx eigerx changed the title Switch bool logs to do_store_logs in pipe_base function call DM-41321: Add try-except block to manifest checker so that failure to get butler logs does not make error reporting impossible Nov 1, 2023
@eigerx
Copy link
Contributor Author

eigerx commented Nov 1, 2023

The rename of "logs" to "do_store_logs" doesn't work on the current stack, but without this the rename in pipe_base will break. The Jenkins run was successful (https://rubin-ci.slac.stanford.edu/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/582/pipeline/). I suspect that the build here will succeed following a merge of the ticket of the same name in pipe_base.

@timj
Copy link
Member

timj commented Nov 1, 2023

The idea is to temporarily change the build branch in requirements.txt

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8caecd3) 87.21% compared to head (0fe5b8c) 87.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files          49       49           
  Lines        4419     4419           
  Branches      762      762           
=======================================
  Hits         3854     3854           
  Misses        407      407           
  Partials      158      158           
Files Coverage Δ
python/lsst/ctrl/mpexec/cli/script/report.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eigerx eigerx merged commit b3351f9 into main Nov 7, 2023
14 checks passed
@eigerx eigerx deleted the tickets/DM-41321 branch November 7, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants