DM-47344: Update plotting in cameraGeom to add integer detector ID label #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the plots are only labeled with the detector's name as returned by detector.getName(). Many users prefer identifying detectors by their integer values as returned by detector.getId() Let's have both!
suberlak
approved these changes
Nov 2, 2024
| @@ -1022,7 +1022,8 @@ def showCamera(camera, imageSource=FakeImageDataSource(), imageFactory=afwImage. | |||
| displayUtils.drawBBox( | |||
| bbox, borderWidth=0.5, ctype=ctype, display=display) | |||
| dims = bbox.getDimensions() | |||
| display.dot(ccd.getName(), bbox.getMinX() + dims.getX()/2, bbox.getMinY() + dims.getY()/2, | |||
| ccdLabel = "{}\n[{}]".format(ccd.getName(), ccd.getId()) | |||
There was a problem hiding this comment.
I guess it doesn't matter much, but was it on purpose that showCcd has {} [{}] and showCamera has {}\n[{}] ( the detId below rather than next to detName )?
There was a problem hiding this comment.
Indeed, it was. The one above is a plot "title", so just keeping it in one line seems preferable. For the focal plane labels, we don't have a lot of horizontal real estate, hence the newline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.