DM-47152: Writing FITS header with long keywords and long strings is broken #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Oct 28, 2024
src/fits.cc
Outdated
| if (keyName.size() > 8 && keyName.rfind("HIERARCH ", 0) != 0) { | ||
| keyName = "HIERARCH " + keyName; | ||
| } | ||
| char const* keyStr = keyName.c_str(); |
There was a problem hiding this comment.
It should be just as fast and a bit safer to just call c_str() whenever you use this variable below (instead of defining the variable, I mean); what you have now is safe, but it would only take a small perturbation for keyStr to get used after keyName goes out of scope.
Otherwise, cfitsio doesn't treat them right. In particular, long string values have the CONTINUE convention messed up, and I've seen it swallow 9 chars from the string value to put in the HIERARCH.
PaulPrice
force-pushed
the
tickets/DM-47152
branch
from
7674041 to
4524374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that long keywords have HIERARCH prepended.
Otherwise, cfitsio doesn't treat them right. In particular, long string values have the CONTINUE convention messed up, and I've seen it swallow chars from the string value to put in the HIERARCH.
Includes a test that fails without this fix.