DM-43855: Rework error reporting for assertImagesAlmostEqual #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-43855
branch
2 times, most recently
from
c04302f to
0c057f6
Compare
parejkoj
force-pushed
the
tickets/DM-43855
branch
from
0c057f6 to
16f0c56
Compare
|
Example error message from this change: |
parejkoj
force-pushed
the
tickets/DM-43855
branch
from
16f0c56 to
222e16c
Compare
TallJimbo
approved these changes
Jun 3, 2024
python/lsst/afw/image/testUtils.py
Outdated
| maxAbsInd = np.where(errArr == maxErr) | ||
| maxAbsTuple = (maxAbsInd[1][0], maxAbsInd[0][0]) | ||
| # NOTE: use the second image, because the numpy test is: | ||
| # (atol + rtol * absolute(b)) |
There was a problem hiding this comment.
I trust this is all right, but this comment and the commit message aren't quite enough for me to easily grasp what it is that allclose is doing. Adding min and/or max to this expression and an inequality might help.
Just reporting the maximum absolute difference does not tell you where np.allclose() was failing, because it uses a relative+absolute comparison. Fix test of error message format for unsigned case.
parejkoj
force-pushed
the
tickets/DM-43855
branch
from
222e16c to
bb3a0c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reporting the maximum absolute difference does not tell you where np.allclose() was failing, because it uses a relative+absolute comparison.