Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39842: Give SimpleTable metadata on construction #728

Merged
merged 2 commits into from
Mar 22, 2024
Merged

DM-39842: Give SimpleTable metadata on construction #728

merged 2 commits into from
Mar 22, 2024

Conversation

parejkoj
Copy link
Contributor

No description provided.

mrawls
mrawls approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to assume your C++ changes do what you intend, here 😄

tests/test_simpleTable.py Outdated Show resolved Hide resolved
parejkoj added 2 commits March 21, 2024 13:55
@parejkoj
SimpleTable should have an empty metadata on construction
87647ed 
Downstream usage should be able to assume that the metadata exists.
@parejkoj
clang-format and test cleanups
2dadf90
@parejkoj parejkoj merged commit 8cdfe0a into main Mar 22, 2024
2 checks passed
@parejkoj parejkoj deleted the tickets/DM-39842 branch March 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrawls mrawls mrawls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parejkoj @mrawls