DM-41345: handle non-finite positions when calculating covariance #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-41345
branch
from
d88df1e to
728f35e
Compare
cmsaunders
approved these changes
Nov 2, 2023
| Eigen::Matrix2d localMatrix = measurementToLocalGnomonic->getJacobian(center); | ||
| Eigen::Matrix2f d = localMatrix.cast < float > () * scale * (lsst::geom::PI / 180.0); |
There was a problem hiding this comment.
I don't know how those spaces got merged! Oops.
| Eigen::Matrix2f calculateCoordCovariance(geom::SkyWcs const& wcs, lsst::geom::Point2D center, Eigen::Matrix2f err) { | ||
| Eigen::Matrix2f calculateCoordCovariance(geom::SkyWcs const &wcs, lsst::geom::Point2D center, | ||
| Eigen::Matrix2f err) { | ||
| if (!std::isfinite(center.getX()) || !std::isfinite(center.getY())) { |
There was a problem hiding this comment.
I think this would be the end result anyway, but I agree it's better to just skip going forward in this situation.
There was a problem hiding this comment.
No, if the center is non-finite, the computed skyCenter will be NaN and the call to geom::makeSkyWcs will raise because it's not a valid WCS.
If either position is NaN, the `makeSkyWcs` call further down will fail because `skyCenter` is also NaN.
parejkoj
force-pushed
the
tickets/DM-41345
branch
from
728f35e to
2e4cf33
Compare
arunkannawadi
pushed a commit
that referenced
this pull request
Dec 6, 2023
DM-41345: handle non-finite positions when calculating covariance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.