Skip to content

Commit

Permalink
Bump Unfurlbot to version 0.3.2
Browse files Browse the repository at this point in the history
Reorganize `values.yaml` somewhat to match the current starter and
remove the obsolete (unused) autoscaling configuration. If we later
want to autoscale this service, we'll need to write a new
configuration for the current API version anyway.

Add labels to a few Kubernetes resources that didn't have them.
  • Loading branch information
rra committed Dec 2, 2024
1 parent 8b697e5 commit 1cab999
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 65 deletions.
2 changes: 1 addition & 1 deletion applications/unfurlbot/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
appVersion: "0.3.1"
appVersion: "0.3.2"
description: Squarebot backend that unfurls Jira issues.
name: unfurlbot
sources:
Expand Down
6 changes: 1 addition & 5 deletions applications/unfurlbot/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ Squarebot backend that unfurls Jira issues.
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| affinity | object | `{}` | Affinity rules for the unfurlbot deployment pod |
| autoscaling.enabled | bool | `false` | Enable autoscaling of unfurlbot deployment |
| autoscaling.maxReplicas | int | `100` | Maximum number of unfurlbot deployment pods |
| autoscaling.minReplicas | int | `1` | Minimum number of unfurlbot deployment pods |
| autoscaling.targetCPUUtilizationPercentage | int | `80` | Target CPU utilization of unfurlbot deployment pods |
| config.jiraProjects | string | See `values.yaml` | Names of Jira projects to unfurl (comma-separated) |
| config.jiraUrl | string | `"https://rubinobs.atlassian.net/"` | Jira base URL |
| config.logLevel | string | `"INFO"` | Logging level: "DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL" |
Expand All @@ -29,7 +25,7 @@ Squarebot backend that unfurls Jira issues.
| global.vaultSecretsPath | string | Set by Argo CD | Base path for Vault secrets |
| image.pullPolicy | string | `"IfNotPresent"` | Pull policy for the unfurlbot image |
| image.repository | string | `"ghcr.io/lsst-sqre/unfurlbot"` | Image to use in the unfurlbot deployment |
| image.tag | string | `""` | Overrides the image tag whose default is the chart appVersion. |
| image.tag | string | The appVersion of the chart | Image tag to use |
| ingress.annotations | object | `{}` | Additional annotations for the ingress rule |
| nodeSelector | object | `{}` | Node selection rules for the unfurlbot deployment pod |
| podAnnotations | object | `{}` | Annotations for the unfurlbot deployment pod |
Expand Down
3 changes: 2 additions & 1 deletion applications/unfurlbot/secrets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ UNFURLBOT_SLACK_APP_ID:
key: SQUAREBOT_SLACK_APP_ID
UNFURLBOT_SLACK_TOKEN:
description: >-
The Slack bot user oauth token for the Slack App shared by all Squarebot services.
The Slack bot user OAuth token for the Slack App shared by all Squarebot
services.
copy:
application: squarebot
key: SQUAREBOT_SLACK_TOKEN
2 changes: 0 additions & 2 deletions applications/unfurlbot/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ metadata:
app.kubernetes.io/component: "server"
app.kubernetes.io/part-of: "unfurlbot"
spec:
{{- if not .Values.autoscaling.enabled }}
replicas: {{ .Values.replicaCount }}
{{- end }}
selector:
matchLabels:
{{- include "unfurlbot.selectorLabels" . | nindent 6 }}
Expand Down
28 changes: 0 additions & 28 deletions applications/unfurlbot/templates/hpa.yaml

This file was deleted.

18 changes: 10 additions & 8 deletions applications/unfurlbot/templates/kafkaaccess.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
apiVersion: access.strimzi.io/v1alpha1
kind: KafkaAccess
metadata:
name: unfurlbot-kafka
name: "unfurlbot-kafka"
labels:
{{- include "unfurlbot.labels" . | nindent 4 }}
spec:
kafka:
name: sasquatch
namespace: sasquatch
listener: tls
name: "sasquatch"
namespace: "sasquatch"
listener: "tls"
user:
kind: KafkaUser
apiGroup: kafka.strimzi.io
name: unfurlbot
namespace: sasquatch
kind: "KafkaUser"
apiGroup: "kafka.strimzi.io"
name: "unfurlbot"
namespace: "sasquatch"
2 changes: 2 additions & 0 deletions applications/unfurlbot/templates/networkpolicy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
name: "unfurlbot"
labels:
{{- include "unfurlbot.labels" . | nindent 4 }}
spec:
podSelector:
matchLabels:
Expand Down
26 changes: 6 additions & 20 deletions applications/unfurlbot/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ image:
# -- Pull policy for the unfurlbot image
pullPolicy: "IfNotPresent"

# -- Overrides the image tag whose default is the chart appVersion.
# -- Image tag to use
# @default -- The appVersion of the chart
tag: ""

config:
Expand Down Expand Up @@ -103,7 +104,6 @@ ingress:
annotations: {}

redis:

# -- Resource requests and limits for the redis pod
# @default -- see `values.yaml`
resources:
Expand All @@ -114,19 +114,11 @@ redis:
cpu: "2m"
memory: "3Mi"

autoscaling:
# -- Enable autoscaling of unfurlbot deployment
enabled: false

# -- Minimum number of unfurlbot deployment pods
minReplicas: 1

# -- Maximum number of unfurlbot deployment pods
maxReplicas: 100
# -- Affinity rules for the unfurlbot deployment pod
affinity: {}

# -- Target CPU utilization of unfurlbot deployment pods
targetCPUUtilizationPercentage: 80
# targetMemoryUtilizationPercentage: 80
# -- Node selection rules for the unfurlbot deployment pod
nodeSelector: {}

# -- Annotations for the unfurlbot deployment pod
podAnnotations: {}
Expand All @@ -141,15 +133,9 @@ resources:
cpu: "9m"
memory: "60Mi"

# -- Node selection rules for the unfurlbot deployment pod
nodeSelector: {}

# -- Tolerations for the unfurlbot deployment pod
tolerations: []

# -- Affinity rules for the unfurlbot deployment pod
affinity: {}

# The following will be set by parameters injected by Argo CD and should not
# be set in the individual environment values files.
global:
Expand Down

0 comments on commit 1cab999

Please sign in to comment.