-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding functionality to read from local database, unit tests #90
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
===========================================
+ Coverage 71.34% 84.71% +13.37%
===========================================
Files 4 14 +10
Lines 164 373 +209
===========================================
+ Hits 117 316 +199
- Misses 47 57 +10 ☔ View full report in Codecov by Sentry. |
Python 3.8 tests are failing because we require a later Pandas version than the latest 3.8-compatible version. I might be able to code my way around this, but if not I'll just set a requirement for Python >= 3.9 and change the tests to test 3.9, 3.10 and 3.11. |
Hey, very awesome! I have just added an example notebook to the PR to demo querying the db file. Hope that's okay. Otherwise it all looks good to me |
Fixes #75.
AdlerPlanetoid.construct_from_SQL()
, which allows population from a SQL database.dataclass_utilities.get_data_table()
to create the data table from a local SQL database. Currently it does this via Pandas because this is the easiest way I know, and Pandas is already a dependency vialsst-rsp
. Probably not optimal behaviour."dp03_catalogs_10yr"
when constructing from the RSP andNone
when pulling from a local database. This is futureproofing, as obviously we won't be pulling data from"dp03_catalogs_10yr"
forever... but it's also the only way I could get the testing database to work :DFixes #31.
Fixes #76.
# pragma: no cover
are ignored by code coverage tools.warnings
to suppress an entirely useless FutureWarning on a Pandas function instead of using Pandas' own in-built suppression, which doesn't work in whatever version of Pandas runs in Python 3.8.Also a few minor fixes - some missing lambdas, tweaks to error messages.
Review Checklist for Source Code Changes