Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dates functionality. #87

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Adding dates functionality. #87

merged 2 commits into from
Mar 19, 2024

Conversation

astronomerritt
Copy link
Collaborator

Fixes #36.

  • You can now specify a date range, either on the command line or when creating an AdlerPlanetoid object in a Jupyter notebook.
  • This is done on the command line with the -d --date_range argument (where you simply follow the flag with two numbers) or on AdlerPlanetoid by passing date_range=[<min_date>, <max_date>] to construct_from_RSP().
  • Dates should be in MJD(TAI).

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt astronomerritt requested a review from jrob93 March 12, 2024 17:20
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.75%. Comparing base (b080dda) to head (c7f11cf).

Files Patch % Lines
src/adler/adler.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   69.84%   68.75%   -1.10%     
==========================================
  Files           3        3              
  Lines          63       64       +1     
==========================================
  Hits           44       44              
- Misses         19       20       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astronomerritt astronomerritt marked this pull request as draft March 14, 2024 17:38
@astronomerritt
Copy link
Collaborator Author

Drafting this as I may have found a bug...

@astronomerritt
Copy link
Collaborator Author

astronomerritt commented Mar 14, 2024

Fixed it.

@astronomerritt astronomerritt marked this pull request as ready for review March 14, 2024 17:50
Copy link
Collaborator

@jrob93 jrob93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@astronomerritt astronomerritt merged commit 188706b into main Mar 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to specify dates on command line
3 participants