Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add astropy and sbypy to requirements #60

Merged
merged 1 commit into from
Mar 5, 2024
Merged

add astropy and sbypy to requirements #60

merged 1 commit into from
Mar 5, 2024

Conversation

mschwamb
Copy link
Collaborator

@mschwamb mschwamb commented Mar 5, 2024

add astropy and sbypy to requirements both for docs (for future demo notebooks) and for pip installation

Fixes #45

  • Does pip install still work?

add astropy and sbypy to requirements both for docs (for future demo notebooks) and for pip installation
@mschwamb mschwamb requested a review from jrob93 March 5, 2024 07:53
@jrob93
Copy link
Collaborator

jrob93 commented Mar 5, 2024

Thanks for adding these Meg. Do we also want to add matplotlib for making plots in demo notebooks?

@mschwamb
Copy link
Collaborator Author

mschwamb commented Mar 5, 2024

That would only need to go into the docs requirements if only the jupyter notebooks demos are going to have plots. My suggestion is if you think the main package will require matplotlib then you open a pull request and follow what I did in this PR to add it. A good way of learning how to add requirements.

@mschwamb
Copy link
Collaborator Author

mschwamb commented Mar 5, 2024

So I would approve this and add in a new issue for matplotlib and make a separate PR for that

@mschwamb mschwamb merged commit a315592 into main Mar 5, 2024
6 checks passed
@mschwamb mschwamb deleted the add_sbpy branch March 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sbpy to requirements
2 participants