Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

143 Adding JSON constructor methods. #144

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

astronomerritt
Copy link
Collaborator

@astronomerritt astronomerritt commented May 23, 2024

Fixes #143.

  • There is now a constructor, AdlerPlanetoid.construct_from_JSON(), which allows you to construct the AdlerPlanetoid object from a JSON file. This is so we can create the object from a Kafka alert.
  • Note that it assumes there is only a single value for each JSON key, i.e. that none of them will be lists.
  • Also note that this has not been unit tested.

Describe your changes.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt astronomerritt requested a review from jrob93 May 23, 2024 14:33
@astronomerritt astronomerritt marked this pull request as draft May 28, 2024 14:40
@astronomerritt astronomerritt marked this pull request as ready for review June 18, 2024 10:35
@astronomerritt astronomerritt merged commit 6f067fc into main Jun 18, 2024
10 checks passed
jrob93 pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add constructor to AdlerPlanetoid to read in from JSON
2 participants