Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

59 renaming project #127

Merged
merged 2 commits into from
May 15, 2024
Merged

59 renaming project #127

merged 2 commits into from
May 15, 2024

Conversation

astronomerritt
Copy link
Collaborator

Fixes #59.

  • Changes the name of the project in pyproject.toml to "lsst-adler" to avoid conflict with an existing PyPi package.
  • Once installed, the actual modules are still accessed in the same way, i.e. from adler.dataclasses.AdlerPlanetoid import AdlerPlanetoid still works, and the adler call on the command line works in the same way. The only thing that is different is the package name.
  • I tested this in a fresh Conda environment with a fresh pip install and it's happy enough but I would VERY MUCH like someone else to double-check.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt astronomerritt marked this pull request as ready for review May 14, 2024 15:49
@astronomerritt astronomerritt requested review from mschwamb and jrob93 May 14, 2024 15:49
@mschwamb mschwamb merged commit abef542 into main May 15, 2024
10 checks passed
@mschwamb mschwamb deleted the 59-renaming branch May 15, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename package for command line
2 participants