Add AOS Configurable Reference Wavefront Block #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmegh
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Thanks for working on this! My only general comment is that it would be nice to be able to specify the rotation angle sequence. I am thinking that, due to time constraints, we may not have time to do this at all the different rotation angles. I do not think that is possible with configurable blocks, however. Maybe to do that we would need to make this a script? Tagging @tribeiro to see what his thoughts are. If we deem a take_reference_wavefront script is necessary, maybe @BekahPolen could also give it a try!
BekahPolen
force-pushed
the
tickets/SITCOM-1460
branch
3 times, most recently
from
51df4ff
to
9bc6d5d
Compare
BekahPolen
force-pushed
the
tickets/SITCOM-1460
branch
from
9bc6d5d
to
81f7b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reference wavefront generation observing json block.