Add files via upload #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the horizons module with a test targets file.
Little changes based on ruff reccomendations.
mkelley
reviewed
Jul 2, 2024
| @dataclass | ||
| class EphemerisData: | ||
| datetime_jd: Time = field(default_factory=lambda: Time([], format="jd")) | ||
| datetime_iso: Time = field(default_factory=lambda: Time([], format="iso")) |
There was a problem hiding this comment.
Only one time attribute is needed. The format can be easily addressed via the Time object's attributes, e.g., EphemerisData.time.jd, EphemerisData.time.mjd, EphemerisData.time.iso, EphemerisData.time.isot.
|
This PR can be closed I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create data class for ephemeris service #4 (comment)
Solution Description
Added the horizons module with a test targets file. Renamed the dataclass elements with the units and switched to Time objects / numpy arrays.