Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix PR review checklist. #25

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

mkelley
Copy link
Collaborator

@mkelley mkelley commented Sep 9, 2024

Looks like I was just missing a close quote.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@b19efc8). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage        ?   77.40%           
=======================================
  Files           ?        6           
  Lines           ?      385           
  Branches        ?        0           
=======================================
  Hits            ?      298           
  Misses          ?       87           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 9, 2024

Before [b19efc8] After [3e017a0] Ratio Benchmark (Parameter)
4.32±0.3s 2.30±1s ~0.53 benchmarks.time_computation
80 3.78k 47.20 benchmarks.mem_list

Click here to view all benchmarks.

@mkelley
Copy link
Collaborator Author

mkelley commented Sep 9, 2024

@mschwamb I think this is good to merge. The "When Opened" action failure is due to the old action being run, not my modified action.

@mschwamb mschwamb self-requested a review September 16, 2024 12:59
@mschwamb mschwamb requested a review from talister September 16, 2024 12:59
@mschwamb
Copy link
Member

Looks good to me. Tagged @talister for the second review to get this merged

Copy link
Collaborator

@talister talister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now...

@mschwamb mschwamb merged commit 578eec8 into lsst-sssc:main Sep 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants