Object detection controller #19

szilac · 2024-08-27T11:48:57Z

Change Description

I have created the objection detection controller (odc) which brings together and manages the various subsystems, such as the ephemeris service, the image service, etc.
Currently it only manages the ephemeris service via command line interface.

new file: forcedphot/odc.py new file: forcedphot/query_args.txt

new file: tests/forcedphot/test_odc.py

modified: tests/forcedphot/ephemeris/test_data_loader.py modified: tests/forcedphot/test_odc.py

…000_2024-06-30_23-59-00.000.ecsv

modified: src/forcedphot/ephemeris/horizons_interface.py modified: src/forcedphot/ephemeris/miriade_interface.py modified: src/forcedphot/odc.py modified: tests/forcedphot/ephemeris/test_ephemeris_client.py modified: tests/forcedphot/ephemeris/test_horizons_interface.py modified: tests/forcedphot/ephemeris/test_miriade_interface.py

github-actions · 2024-08-27T11:51:04Z

Before [`578eec8`]	After [`53a6ae0`]	Ratio	Benchmark (Parameter)
3.34±0.7s	1.78±1s	~0.53	benchmarks.time_computation
1.11k	3.71k	3.34	benchmarks.mem_list

Click here to view all benchmarks.

modified: src/forcedphot/ephemeris/ephemeris_client.py modified: src/forcedphot/odc.py modified: tests/forcedphot/ephemeris/test_data_loader.py modified: tests/forcedphot/test_odc.py

modified: tests/forcedphot/test_odc.py

mkelley · 2024-08-27T17:08:15Z

Thank you for your contribution to ssoforcedphot, a LINCC Framework package! 🌌 This checklist is meant to remind pull request reviewers of some common things to look for.

Do the proposed changes accomplish the desired goals and meet the acceptance criteria of the related issue?
Do the proposed changes follow the coding guidelines?
Are tests added/updated as needed? Are methods requiring network access mocked for offline testing?
Is there sufficient documentation for the changes?

akoumjian

I would remove all the commented out code, save it to another branch if you want to save it for future use.

src/forcedphot/odc.py

mschwamb · 2024-09-03T18:09:10Z

@carrholt and @ijiraq Would you be able to review by Sep10th?

carrholt · 2024-09-10T21:10:19Z

src/forcedphot/odc.py

+        --ecsv:
+            Path to ECSV file containing input data.
+
+        --csv:


should give more info on how the csv file should be set up. Based on the test file, it looks like the column headers are named the specific args? But I may be wrong here.

In the tests/forcedphot/ephemeris/data folder, I added a template_ephemeris.ecsv file that can be used as a template.

carrholt · 2024-09-10T21:12:59Z

src/forcedphot/query_args.txt

if used for tests, should be moved a data directory in tests or if it's being used as an example, it should probably still go elsewhere.

You are absolutely right, I moved it to the tests/forcedphot/ephemeris/data folder.

carrholt · 2024-09-10T21:20:49Z

src/forcedphot/odc.py

+    service selection, target specification, time range settings, input file
+    handling, and various service configurations.
+
+    Command-line Arguments:


The filter(s) a user wants to query should be an argument for all but the ephemeris service. It should be able to receive a single filter or list of filters (e.g., [g,r])

Yes, this argument was left out. I have included it.
It's not connected to anything at the moment, but as soon as the image service is up and running, it will be used.

carrholt

add a filter argument and move query_args.txt

modified: src/forcedphot/ephemeris/horizons_interface.py modified: src/forcedphot/ephemeris/miriade_interface.py modified: src/forcedphot/odc.py new file: tests/forcedphot/ephemeris/data/query_args.txt new file: tests/forcedphot/ephemeris/data/query_args2.txt new file: tests/forcedphot/ephemeris/data/template_ephemeris.ecsv

jrob93 · 2024-10-25T14:47:19Z

I just made some small changes as the conda command in README.md wasn't working for me and there was a typo in odc.py

jrob93

I think this all works nicely for the current task of retrieving ephemerides for a given object(s). At some point in the future it would be good to have more documentation on exactly how CLI arguments such as --target-type relates to the Horizons/Miriade query. I had comments on the CLI arguments relating to other aspects of the package (issue #13) but I think this can be merged now and these other details sorted when they are being worked on

szilac added 5 commits August 19, 2024 12:35

modified: forcedphot/ephemeris/ephemeris_client.py

c5de048

new file: forcedphot/odc.py new file: forcedphot/query_args.txt

modified: src/forcedphot/odc.py

2ce7996

new file: tests/forcedphot/test_odc.py

modified: src/forcedphot/ephemeris/data_loader.py

7d05871

modified: tests/forcedphot/ephemeris/test_data_loader.py modified: tests/forcedphot/test_odc.py

new file: tests/forcedphot/ephemeris/data/Encke_2024-01-01_00-00-00.…

85a5760

…000_2024-06-30_23-59-00.000.ecsv

szilac added 8 commits August 27, 2024 14:11

modified: src/forcedphot/ephemeris/data_loader.py

46f0179

modified: src/forcedphot/ephemeris/ephemeris_client.py modified: src/forcedphot/odc.py modified: tests/forcedphot/ephemeris/test_data_loader.py modified: tests/forcedphot/test_odc.py

modified: tests/forcedphot/test_odc.py

d3585d4

modified: src/forcedphot/odc.py

5668592

modified: tests/forcedphot/test_odc.py

modified: src/forcedphot/odc.py

c89bb1d

modified: src/forcedphot/odc.py

df0f349

modified: src/forcedphot/odc.py

0eb060b

modified: src/forcedphot/ephemeris/ephemeris_client.py

0cd80da

modified: tests/forcedphot/ephemeris/test_data_loader.py

2cd2b8e

talister requested a review from ijiraq August 27, 2024 17:12

talister self-assigned this Aug 27, 2024

talister requested a review from carrholt August 27, 2024 17:15

akoumjian requested changes Sep 3, 2024

View reviewed changes

src/forcedphot/odc.py Show resolved Hide resolved

carrholt reviewed Sep 10, 2024

View reviewed changes

carrholt requested changes Sep 10, 2024

View reviewed changes

szilac added 6 commits October 1, 2024 12:33

modified: src/forcedphot/odc.py

6100566

modified: tests/forcedphot/ephemeris/test_data_loader.py

e023863

modified: src/forcedphot/odc.py

cb87396

modified: tests/forcedphot/ephemeris/test_data_loader.py

b2324f8

modified: tests/forcedphot/ephemeris/test_data_loader.py

29fd3b9

szilac and others added 5 commits October 1, 2024 12:57

modified: tests/forcedphot/ephemeris/test_data_loader.py

4345f50

modified: src/forcedphot/odc.py

13eff44

modified: src/forcedphot/odc.py

63c12c6

modified: src/forcedphot/odc.py

8f6ddc8

fix typos

de97609

mschwamb requested a review from jrob93 October 29, 2024 11:48

jrob93 approved these changes Oct 29, 2024

View reviewed changes

carrholt approved these changes Oct 29, 2024

View reviewed changes

talister requested a review from akoumjian November 5, 2024 18:03

akoumjian approved these changes Nov 12, 2024

View reviewed changes

szilac merged commit 8fe0fc1 into main Nov 12, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Object detection controller #19

Object detection controller #19

szilac commented Aug 27, 2024

github-actions bot commented Aug 27, 2024 •

edited

Loading

mkelley commented Aug 27, 2024 •

edited by hhsieh00

Loading

akoumjian left a comment

mschwamb commented Sep 3, 2024

carrholt Sep 10, 2024 •

edited

Loading

szilac Oct 1, 2024

carrholt Sep 10, 2024 •

edited

Loading

szilac Oct 1, 2024

carrholt Sep 10, 2024 •

edited

Loading

szilac Oct 1, 2024

carrholt left a comment •

edited

Loading

jrob93 commented Oct 25, 2024

jrob93 left a comment

Object detection controller #19

Object detection controller #19

Conversation

szilac commented Aug 27, 2024

Change Description

github-actions bot commented Aug 27, 2024 • edited Loading

mkelley commented Aug 27, 2024 • edited by hhsieh00 Loading

akoumjian left a comment

Choose a reason for hiding this comment

mschwamb commented Sep 3, 2024

carrholt Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

szilac Oct 1, 2024

Choose a reason for hiding this comment

carrholt Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

szilac Oct 1, 2024

Choose a reason for hiding this comment

carrholt Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

szilac Oct 1, 2024

Choose a reason for hiding this comment

carrholt left a comment • edited Loading

Choose a reason for hiding this comment

jrob93 commented Oct 25, 2024

jrob93 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 27, 2024 •

edited

Loading

mkelley commented Aug 27, 2024 •

edited by hhsieh00

Loading

carrholt Sep 10, 2024 •

edited

Loading

carrholt Sep 10, 2024 •

edited

Loading

carrholt Sep 10, 2024 •

edited

Loading

carrholt left a comment •

edited

Loading