Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a review checklist on newly opened PRs #14

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

mkelley
Copy link
Collaborator

@mkelley mkelley commented Aug 18, 2024

Review checklist

Closes #12

Solution Description

Added an action to the github workflows that comments on a newly opened pull request with the review checklist.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
    I'm not sure how to test this.
  • My code contains relevant comments and necessary documentation

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

Before [0de6be8] After [491d10b] Ratio Benchmark (Parameter)
872 2.59k 2.97 benchmarks.mem_list
2.30±1s 2.21±1s 0.96 benchmarks.time_computation

Click here to view all benchmarks.

@mschwamb mschwamb requested review from mschwamb and talister August 20, 2024 16:37
Copy link
Collaborator

@talister talister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm....

@mschwamb mschwamb merged commit eab97bd into lsst-sssc:main Aug 20, 2024
7 checks passed
@mschwamb
Copy link
Member

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review checklist?
4 participants