Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for in-kind contribution
JAP-JPG-S3
from NAOJ #3913base: main
Are you sure you want to change the base?
Changes for in-kind contribution
JAP-JPG-S3
from NAOJ #3913Changes from all commits
255bbd9
4df4758
6383001
cc9b8a0
109c0d4
75329da
8780777
10da8e9
e4721c4
11c472c
f7bfeb3
7712cec
061f41c
d793ad0
01b2b2e
701fb1e
8cd52a1
53ff699
1d68dc2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should provide the ability to set additional information like resource requests and limits in these deployments. Another thing that may be necessary to configure, especially for the generator, is
tolerations
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in ab67731, c2f5203, 192b0f8