Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47507: Fix migration workflow #56

Merged
merged 1 commit into from
Nov 16, 2024
Merged

DM-47507: Fix migration workflow #56

merged 1 commit into from
Nov 16, 2024

Conversation

JeremyMcCormick
Copy link
Contributor

@JeremyMcCormick JeremyMcCormick commented Nov 15, 2024 •
edited
Loading

This PR fixes some issues in the migration workflow where the branch and ticket names were not being extracted correctly.

@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-47507-fix-migration-workflow branch from 363a27d to a2e758c Compare November 15, 2024 11:18
ktlim
ktlim approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@ktlim ktlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the basic lesson here is that GITHUB_ENV doesn't take effect immediately, only in later steps, right?

@JeremyMcCormick
Copy link
Contributor Author

So the basic lesson here is that GITHUB_ENV doesn't take effect immediately, only in later steps, right?

Yes, this was the main problem that was fixed.

@JeremyMcCormick JeremyMcCormick merged commit 64b1cc5 into main Nov 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktlim ktlim ktlim approved these changes

@Vebop Vebop Awaiting requested review from Vebop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyMcCormick @ktlim