Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47125 Add unit test for ccdexposure insert with multi-column primary keys #55

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

bbrondel
Copy link
Collaborator

I verified that the unit test works as intended by the following procedure:

 git switch --detach b5b38981d56f3f19989fbf388f77ca00fb5ee69c
 git cherry-pick a81aefd
 # In ./Dockerfile.pytest, change OBS_LSST_VERSION=w_2024_32 to OBS_LSST_VERSION=d_latest
 docker run -it $(docker build -q -f Dockerfile.pytest .)
 # the test fails
 git switch tickets/DM-47125
 # the change to Dockerfile.pytest carries over
 # and the test passes

I also updated the Dockerfile.pytest to use a more recent build of the LSST environment.

@bbrondel bbrondel requested a review from Vebop November 14, 2024 18:23
Copy link
Collaborator

@Vebop Vebop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding how you tested it to the description

@bbrondel bbrondel merged commit 801263b into main Nov 14, 2024
7 checks passed
@bbrondel bbrondel deleted the tickets/DM-47125 branch November 14, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants