Add workflow for pytest #29
Conversation
There was a problem hiding this comment.
Some quick comments to let you make progress on these passing before I look again.
You will need to manually rebase to get rid of the merge from main.
@ktlim this package doesn't use fastapi or the square approach to dependency management for services?
.github/workflows/pytest.yaml
Outdated
|
|
||
| jobs: | ||
| run_lint: | ||
| uses: lsst/rubin_workflows/.github/workflows/lint.yaml@main |
There was a problem hiding this comment.
You can remove these two lines because the package already has lint.yaml in it. What needs to be done though is to replace the contents of lint.yaml with the standard version (eg from https://github.com/lsst/pipe_tasks/blob/main/.github/workflows/lint.yaml) since the one in this repo is old and hasn't been changed to use the reusable workflow.
.github/workflows/pytest.yaml
Outdated
| - name: Editable mode install | ||
| run: | | ||
| python -m pip install uv | ||
| uv pip install pytest |
There was a problem hiding this comment.
| uv pip install pytest | |
| uv pip install --system pytest |
uv needs to be forced to use the system python.
.github/workflows/pytest.yaml
Outdated
| run: | | ||
| python -m pip install uv | ||
| uv pip install pytest | ||
| uv pip install -e . |
There was a problem hiding this comment.
| uv pip install -e . | |
| uv pip install --system -e . |
bbrondel
force-pushed
the
tickets/DM-45314
branch
from
cb58425 to
60f7e23
Compare
This change adds a GitHub workflow for pytest and makes modifications that allow the tests to run. It does not correct one failing test. This PR includes changes responsive to comments by @ktlim and @timj. It doesn't fully address DM-45314, but I'd like to go ahead and get this in and then add another ticket.