Skip to content

Commit

Permalink
linting and precommit
Browse files Browse the repository at this point in the history
  • Loading branch information
Vebop committed Nov 8, 2024
1 parent 9a1dc89 commit b254121
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions alembic-autogenerate.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# 1. Load the LSST environment and setup sdm_schemas and felis.
# source loadLSST.bash or activate your eups setup
# setup felis
# setup -r /path/to/sdm_schemas -- SDM_SCHEMAS_DIR could hopefully just work
# setup -r /path/to/sdm_schemas -- SDM_SCHEMAS_DIR should work
# 2. From the root of the consdb git repo, invoke the script. Supply a
# revision message as the command line argument:
# python alembic-autogenerate.py this is my revision message "\n" \
Expand All @@ -20,11 +20,11 @@
import re
import sys

from alembic.config import Config
from alembic import command
from felis.tests.postgresql import setup_postgres_test_db
from sqlalchemy.sql import text

from felis.tests.postgresql import setup_postgres_test_db
from alembic import command
from alembic.config import Config

if len(sys.argv) <= 1:
print(
Expand Down
2 changes: 1 addition & 1 deletion doc/developer-guide/consdbclient-summit-utils.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
ConsDbClient in summit_utils
############################

How to write and test code in summit_utils for ConsDbClient
How to write and test code in summit_utils for ConsDbClient
2 changes: 1 addition & 1 deletion doc/operator-guide/monitoring.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ Monitoring

- Other issues
- K8s infrastructure died The ConsDB team can verify that that is the problem, but there are likely to be wider issues seen
- USDF or Summit K8s/IT support should be responsible for fixing.
- USDF or Summit K8s/IT support should be responsible for fixing.
4 changes: 2 additions & 2 deletions doc/operator-guide/schema-migration-process.rst
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Schema Migration Process


- If tests are successful, create a pull request for the Alembic migration in `consdb`. Tag the release according to `standards-practices` guidelines.
- Update your existing phalanx branch to point the environment based deployments to this consdb tag. You are able to retest on the test stand at this point, hopefully there were no changes to your consdb pull request so this step is trivial.
- Update your existing phalanx branch to point the environment based deployments to this consdb tag. You are able to retest on the test stand at this point, hopefully there were no changes to your consdb pull request so this step is trivial.

* Deploy migration in synchrony at Summit (if necessary), USDF, and Prompt Release (if necessary)

Expand Down Expand Up @@ -99,4 +99,4 @@ Schema Migration Process
4. Have an image taken with the observing team, then verify database entries with a SQL query or Jupyter notebook.
5. Check your new entries in the database using a jupyter notebook or SQL query in RSP showing your new image has been inserted to the database as expected.

- Once deployment succeeds, set the `Target Revision` in `argo-cd` back to `main` and complete the `phalanx` PR for the tested `consdb` tag.
- Once deployment succeeds, set the `Target Revision` in `argo-cd` back to `main` and complete the `phalanx` PR for the tested `consdb` tag.
2 changes: 1 addition & 1 deletion doc/user-guide/consdb-client-library-in-summit-utils.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
ConsDB Client Library in summit_utils
######################################

Querying using ConsDbClient
Querying using ConsDbClient
2 changes: 1 addition & 1 deletion doc/user-guide/schemas.rst
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ https://rubin-obs.slack.com/archives/C07QJMQ7L4A/p1730482605167509
What do users see, how does TAP play into this, do the schema need this type of micro versioning?


Services/cosndb repo versioning strategy - services of monthly YY.0M.DD
Services/cosndb repo versioning strategy - services of monthly YY.0M.DD

0 comments on commit b254121

Please sign in to comment.