Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with ASAN #647

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

rocallahan
Copy link
Contributor

This revealed the issue addressed by #646. Tests will fail without that fix.

@rocallahan rocallahan marked this pull request as draft June 27, 2024 03:51
@rocallahan
Copy link
Contributor Author

The ASAN test failed as expected. When #646 is merged, this will be ready for review and merge.

@rocallahan rocallahan marked this pull request as ready for review June 27, 2024 20:44
@rocallahan rocallahan force-pushed the support-asan branch 2 times, most recently from 77e4631 to 553772c Compare June 27, 2024 21:04
@rocallahan rocallahan marked this pull request as draft July 1, 2024 05:06
@rocallahan
Copy link
Contributor Author

Sorry, we need to -DADDRESS_SANITIZER as well, and that reveals more issues, so I need to work on this some more.

@costamag costamag requested a review from lee30sonia July 11, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant