Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract adders updates #631

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

aletempiac
Copy link
Member

This PR includes:

  • Adding tests for decompose_multioutput util
  • Fixes in decompose_multioutput util
  • Experiment for extract_adder
  • Comments in block_network to help the user understanding how HAs and FAs are created

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1134d1d) 83.68% compared to head (4fdb61d) 83.59%.

Files Patch % Lines
.../algorithms/experimental/decompose_multioutput.hpp 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   83.68%   83.59%   -0.09%     
==========================================
  Files         186      187       +1     
  Lines       29617    29740     +123     
==========================================
+ Hits        24784    24862      +78     
- Misses       4833     4878      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aletempiac aletempiac merged commit c65f3f6 into lsils:master Feb 19, 2024
17 checks passed
@aletempiac aletempiac deleted the extract_adders_updates branch February 20, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants