CMake: Include libenet.pc in installation #233
Conversation
The rest might still be nice to have. Could you rebase this pull request @h3xx? |
- Add missing project version - Fix missing shared library symlinks
h3xx
changed the title
h3xx
force-pushed
the
use-gnuinstalldirs
branch
from
6173e03
to
f675709
Compare
| @@ -104,6 +110,16 @@ install(TARGETS enet | |||
| ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | |||
| LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | |||
| ) | |||
| install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/enet | |||
There was a problem hiding this comment.
Why did you remove ${CMAKE_CURRENT_SOURCE_DIR}?
There was a problem hiding this comment.
It's not necessary. Per the CMake documentation for install() (https://cmake.org/cmake/help/latest/command/install.html):
The
FILESform [i.e.install(FILES...)orinstall(DIRECTORY...)] specifies rules for installing files for a project. File names given as relative paths are interpreted with respect to the current source directory. Files installed by this form are by default given permissionsOWNER_WRITE,OWNER_READ,GROUP_READ, andWORLD_READif noPERMISSIONSargument is given.
Try it! :-)
There was a problem hiding this comment.
Thanks, this part looks good to me.
Don't have the knowledge to review the rest
|
This looks good to me and does what I would expect. |
|
@Croydon Can you please get this and the LANGUAGES CMake patch in? |
I am just another community member and can't do such a thing, sorry. |
Oh, my misunderstanding. I saw you in various tickets and PRs and thought maybe you were associated with the project. |
Use GNUInstallDirs to determine install pathsFix missing shared library symlinks(Prior PR)Don't default to building static libenet (Use(Prior PR)-DBUILD_SHARED_LIBS=(ON|OFF)to control whether to build shared-only (ON) or static-only (OFF) libraries.)Does not break existing ability to build using GNU Autotools. In fact, it fixes some compatibility with it (GNU Autotools installs the .pc file, therefore so should CMake).
Closes #243