-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Ignore build directory in Jest's module path
#9995
Development
: Ignore build directory in Jest's module path
#9995
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
jest.config.js
(1 hunks)
🔇 Additional comments (1)
jest.config.js (1)
131-131
: LGTM! This change appropriately addresses the module naming collisions.
The addition of <rootDir>/build/
to modulePathIgnorePatterns is the correct approach to prevent Jest from detecting duplicate modules in the build directory. This aligns with Jest's recommended practices for handling module resolution conflicts.
Checklist
General
Motivation and Context
Currently, client tests always start with this message:
Jest detects the package.json files in the build directory and tries to add them as modules.
Description
The
modulePathIgnorePatterns
option of Jest is used to ignore the build directory, like it's already done with the template resources.Review Progress
Code Review
Summary by CodeRabbit