Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Fix an issue with duplicated posts on course wide search #9819

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Communication: Fix an issue with duplicated posts on course wide search #9819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b7239c
Remove duplicates from the search result
cremertim Nov 19, 2024
4950c6c
Merge branch 'develop' into bugfix/communication/show-post-once-per-s…
cremertim Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/de/tum/cit/aet/artemis/communication/repository/CustomPostRepositoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package de.tum.cit.aet.artemis.communication.repository;

import java.util.ArrayList;
import java.util.Collections;
import java.util.LinkedHashSet;
import java.util.List;

import jakarta.persistence.EntityManager;
Expand Down Expand Up @@ -50,6 +52,8 @@ public Page<Long> findPostIdsWithSpecification(Specification<Post> specification
query.setMaxResults(pageable.getPageSize());

List<Long> postIds = query.getResultList();
// removes all duplicates from the answer posts
List<Long> uniquePostIds = new ArrayList<>(new LinkedHashSet<>(postIds));
MaximilianAnzinger marked this conversation as resolved.
Show resolved Hide resolved

// Count query
CriteriaQuery<Long> countQuery = builder.createQuery(Long.class);
Expand All @@ -66,6 +70,6 @@ public Page<Long> findPostIdsWithSpecification(Specification<Post> specification
Long countResult = entityManager.createQuery(countQuery).getSingleResult();
long count = countResult != null ? countResult : 0L;

return new PageImpl<>(postIds, pageable, count);
return new PageImpl<>(uniquePostIds, pageable, count);
}
}
Loading