Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Improve docker compose setup documentation #9816

Merged

Conversation

b-fein
Copy link
Contributor

@b-fein b-fein commented Nov 18, 2024

Checklist

General

Motivation and Context

As noted by @magaupp in #9790 (comment), the upgrade steps for Jenkins in Docker Compose and direct Docker (no Compose) setups are different. The --no-cache option should be provided for both to ensure the latest plug-in versions are integrated into the container.

Description

Updates the Docker Compose command to include the --no-cache like the one in the step below.
Also fixes a few typos in the other Docker Compose setup documentation.

Steps for Testing

Code review only.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@coderabbitai ignore

Copy link
Contributor

@magaupp magaupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@b-fein b-fein added this to the 7.7.2 milestone Nov 19, 2024
Copy link

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krusche krusche changed the title Development: Improve Docker Compose setup documentation Development: Improve docker compose setup documentation Nov 20, 2024
@krusche krusche merged commit d7ca737 into develop Nov 20, 2024
34 checks passed
@krusche krusche deleted the bugfix/documentation/jenkins-docker-compose-upgrade branch November 20, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants