-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication
: Allow user to forward messages
#9794
base: develop
Are you sure you want to change the base?
Conversation
…e-message-view' into feature/communication/consecutive-message-view
…-view # Conflicts: # src/main/webapp/app/overview/course-conversations/layout/conversation-messages/conversation-messages.component.ts # src/main/webapp/app/shared/metis/answer-post/answer-post.component.scss
export class ForwardMessageDialogComponent implements OnInit, AfterViewInit { | ||
channels = signal<ChannelDTO[] | []>([]); | ||
users = signal<UserPublicInfoDTO[] | []>([]); | ||
postToForward = signal<Post | null>(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we prefer undefined
over null
in the client code, see the client coding guidelines
} | ||
|
||
@Component({ | ||
selector: 'jhi-forward-message-dialog', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the new component not standalone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we prefer
undefined
overnull
in the client code, see the client coding guidelines - please make all new components standalone
- client tests need to pass (including test coverage)
4016e8c
…are-message' into feature/communication/forward-share-message
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS5. Works as expected!
Checklist
General
Server
Client
Motivation and Context
Currently user cannot forward messages to other channels/direct-group chats.
(Closes #9066)
Description
The forward message feature has been added. Users can now navigate to the forward message dialog by clicking on the forward message option. They can select a random number of destinations and add content to the forwarded message (similar to Slack).
forwarded_message
table has been added to the database with the following fields:post
andanswer_post
table have been updated with a new column named has_forwarded_messages.Known Issue for a followup PR:
The server-side changes for forwarding multiple messages within a single message and forwarding a message as a reply to another message (inside an AnswerPost) are already in place, but the client-side implementation is not ready yet. To achieve this, a unique message link needs to be generated for each post/answer post, similar to the "Copy Link" feature in Slack. This will be completed in a follow-up PR.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Performance Tests
Test Coverage
Client
Screenshots
forwarded message view
forward message dialog
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Post
andAnswerPost
classes to track forwarded messages.ConversationMessagesComponent
to handle forwarded messages and navigation.MetisConversationService
for creating group and direct conversations.Bug Fixes
Documentation
Style
Tests
Chores