-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plagiarism checks
: Add direct link to case view
#9747
Plagiarism checks
: Add direct link to case view
#9747
Conversation
Development
: Add direct link to plagiarism detection case view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, can you give a bit more info on how to trigger the plagiarism detection in the test steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me , just one small comment
.../app/course/plagiarism-cases/instructor-view/plagiarism-cases-instructor-view.component.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in testing session, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS2, reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reapprove 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS2. Works as expected.
Plagiarism checks
: Add direct link to plagiarism detection case viewPlagiarism checks
: Add direct link to case view
Checklist
General
Client
Motivation and Context
Fixes #5974 .
In plagiarism cases' page should be a link to view directly the plagiarism detection for the exercises. This issue adds a link for every plagiarism case to the plagiarism detection view for that exercise.
Description
A routerLink was added to the plagiarism detection view, enabling navigation to the respective course and exercise based on their IDs. A new class was introduced to group plagiarism cases by exercise, improving clarity and organization. Additionally, tests were implemented to verify the functionality of the routerLink.
Steps for Testing
Prerequisites:
Testing:
3. Click on the linked "Appears in x comparison(s)" text*Code Review
Manual Tests
Test Coverage
Screenshots
Summary by CodeRabbit
Release Notes
New Features
Style
Tests
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Style
Tests
Documentation