Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plagiarism checks: Add direct link to case view #9747

Merged

Conversation

AjayvirS
Copy link
Contributor

@AjayvirS AjayvirS commented Nov 11, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Fixes #5974 .

In plagiarism cases' page should be a link to view directly the plagiarism detection for the exercises. This issue adds a link for every plagiarism case to the plagiarism detection view for that exercise.

  • Note: as discussed with @MarkusPaulsen and @rabeatwork , this issue was modified to have link near the exercise name instead of the "Appears in x comparison(s)" link for grouped plagiarism submissions of an exercise. The motivation is that every "Appears in..." of one exercise links to the same plagiarism detection view of the exercise, making it redundant.

Description

A routerLink was added to the plagiarism detection view, enabling navigation to the respective course and exercise based on their IDs. A new class was introduced to group plagiarism cases by exercise, improving clarity and organization. Additionally, tests were implemented to verify the functionality of the routerLink.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • At least 2 Exercises (any type) which trigger plagiarism detection

Testing:

  1. Login as instructor and navigate to the assessment dashboard
  2. Go to the plagiarism cases view
    3. Click on the linked "Appears in x comparison(s)" text*
  3. Click on the Exercise name which is linked to the plagiarism detection view for that exercise
  4. Verify if the plagiarism detection view is correctly linked
  • Note: as discussed with @MarkusPaulsen, this issue was modified to link the exercise title instead of the "Appears in x comparison(s)" for every plagiarism submission of an exercise. The motivation is that every "Appears in..." of one exercise links to the plagiarism detection for the same exercise, making it redundant.

x





Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Class/File Line Coverage Confirmation (assert/expect)
plagiarism-cases-instructor-view.component.ts 97%

Screenshots

image

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced navigation in the plagiarism cases instructor view, allowing users to click through to relevant plagiarism detection pages.
    • Improved display of plagiarism submission counts with dynamic IDs for better tracking.
    • Introduced a new structure for grouping plagiarism cases by exercise, enhancing organization and clarity.
    • Added optional chaining for better error handling in student properties.
  • Style

    • Introduced new styles for text elements, including hover effects to improve user interaction feedback.
  • Tests

    • Expanded test coverage for navigation functionality and user interactions, ensuring robust validation of the component's features.

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced instructor view for plagiarism cases with improved navigation and interactivity.
    • Added functionality to view comparisons of plagiarism cases in both English and German.
  • Bug Fixes

    • Improved error handling for undefined student properties in plagiarism cases.
  • Style

    • Introduced new styles for better visual feedback on hover actions.
  • Tests

    • Expanded test suite to include routing capabilities and additional user interaction scenarios.
  • Documentation

    • Updated translation files to include new keys for viewing comparisons.

@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) labels Nov 11, 2024
@AjayvirS AjayvirS changed the title Development: add direct link to plagiarism detection case view from c… Development: add direct link to plagiarism detection case view Nov 11, 2024
@AjayvirS AjayvirS changed the title Development: add direct link to plagiarism detection case view Development:add direct link to plagiarism detection case view Nov 11, 2024
@AjayvirS AjayvirS changed the title Development:add direct link to plagiarism detection case view Development: Add direct link to plagiarism detection case view Nov 11, 2024
@HawKhiem HawKhiem temporarily deployed to artemis-test4.artemis.cit.tum.de November 12, 2024 17:02 — with GitHub Actions Inactive
HawKhiem
HawKhiem previously approved these changes Nov 12, 2024
Copy link

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS4. Works as described

Screenshot 2024-11-12 182252
Screenshot 2024-11-12 182304

Copy link
Contributor

@eceeeren eceeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, can you give a bit more info on how to trigger the plagiarism detection in the test steps?

Copy link
Contributor

@az108 az108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me , just one small comment

@AjayvirS AjayvirS requested a review from eceeeren November 14, 2024 16:32
Copy link
Contributor

@magaupp magaupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2. Link works as expected.
image
image

Copy link
Contributor

@coolchock coolchock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session, works as expected

Copy link

@sachmii sachmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2, reapprove

Copy link
Contributor

@az108 az108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reapprove 👍

Copy link

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

Copy link
Contributor

@MarkusPaulsen MarkusPaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2. Works as expected.

@krusche krusche added this to the 7.8.1 milestone Dec 24, 2024
@krusche krusche added the maintainer-approved The feature maintainer has approved the PR label Dec 24, 2024
@krusche krusche merged commit 8ace45f into develop Dec 24, 2024
61 of 75 checks passed
@krusche krusche deleted the chore/general/5974-link-plagiarism-detection-case-view branch December 24, 2024 07:24
@krusche krusche changed the title Plagiarism checks: Add direct link to plagiarism detection case view Plagiarism checks: Add direct link to case view Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) maintainer-approved The feature maintainer has approved the PR ready to merge tests
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Plagiarism checks: Link the plagiarism detection from the plagiarism case view.