-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication
: Add undo button when deleting posts
#9624
Communication
: Add undo button when deleting posts
#9624
Conversation
…ion/add-undo-delete-button
Communication
: Add undo delete buttonCommunication
: Add undo button when deleting posts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Server tested on: Server 01
Works as expected. I think the error that you talked about earlier in the conversation is now fixed. Or at least, I couldn't reproduce it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS2, everything worked as expected from the description. However, I have also tried switching to another channel while waiting for the timer to countdown, when I am back to the previous channel, the message did not get deleted and remain there. Not sure if this is the intended behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual tested on TS2. It worked as expected, and I tested it in threads, too. It also worked when you delete the main question ->, and then the threads get deleted, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, tested on TS2
Checklist
General
Client
Motivation and Context
Currently, messages are deleted by selecting the trash icon on a post and then confirming the action by clicking the checkmark in the same location. While this confirmation step helps prevent accidental deletions, the double-clicking action commonly used in user interfaces may still lead to unintended deletions. To address this, an additional mechanism should be introduced, allowing users to undo a delete action for a brief period, similar to e.g. the "undo send" functionality in the Mac OS Mail app.
Description
A brief delay has been added before permanently deleting a message, allowing users an opportunity to undo their delete command. This delay is accompanied by user interface elements designed to clearly indicate the status and timing of the deletion process.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Test Coverage
Client
�
Screenshots
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Localization
Tests